Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/1131#issuecomment-187366632
  
    I don't think the blacklist is going to work in general since it is 
possible in Storm to get multiple ack or fail messages for the same messageId. 
I think it would be better to empty `emittedTuples` and `failedTuples` on 
rebalance and determine if a message should be ignored based on its membership 
in those maps. 
    
    Everything else looks pretty good besides normal cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to