[
https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167286#comment-15167286
]
ASF GitHub Bot commented on STORM-1038:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/728#issuecomment-188822872
Yes I am aware of it. We are in the process of merging with the JStorm
project, and part of this merger involves moving most of the clojure code to
java. In all likelihood the degradation is due to reflection happening on the
critical path because many new places in the code are calling into java that
were not doing so before. I plan on doing some profiling soon and submit some
fixes, but it is very much a moving target so I have not been very motivated to
do so. The code for the netty messaging layer should stay mostly the same
between 1.0 and 2.0 for this, so if you want to do your work based off of the
1.0 branch and show performance comparisons there being the same I would
totally accept that as proof that the code is good.
- Bobby
On Thursday, February 25, 2016 12:53 AM, Sun <[email protected]>
wrote:
@revans2 Just merged code from master and seems there is performance
degradation with recent changes. I noticed that it not only affects this
branch, but also the master branch. Here are the comparison on my laptop for
running the perf test with only 5,000/sec throughput with code from
master.Before (git hash: 3db9680)
netty3-r5000.txtNow (git hash: bd396b3)
netty3-new-r5000.txtNote: when running the latest code, my CPU is almost
100% busy which may explain why it was so much worse. When running the "old"
code, my CPU still had 10% idle time.-thanks—
Reply to this email directly or view it on GitHub.
> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
> Key: STORM-1038
> URL: https://issues.apache.org/jira/browse/STORM-1038
> Project: Apache Storm
> Issue Type: Dependency upgrade
> Components: storm-core
> Reporter: Hang Sun
> Priority: Minor
> Labels: performance
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more
> efficient memory usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
