[
https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167303#comment-15167303
]
ASF GitHub Bot commented on STORM-1574:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1149#discussion_r54109478
--- Diff:
storm-core/test/jvm/org/apache/storm/utils/WorkerBackpressureThreadTest.java ---
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.utils;
+
+import java.util.concurrent.atomic.AtomicLong;
+import org.junit.Assert;
+import org.junit.Test;
+import junit.framework.TestCase;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class WorkerBackpressureThreadTest extends TestCase {
+ private static final Logger LOG =
LoggerFactory.getLogger(WorkerBackpressureThreadTest.class);
+
+ @Test
+ public void testNormalEvent() throws Exception {
+ Object trigger = new Object();
+ AtomicLong workerData = new AtomicLong(0);
+ WorkerBackpressureCallback callback = new
WorkerBackpressureCallback() {
+ @Override
+ public void onEvent(Object obj) {
+ ((AtomicLong) obj).getAndDecrement();
+ }
+ };
+ WorkerBackpressureThread workerBackpressureThread = new
WorkerBackpressureThread(trigger, workerData, callback);
+ workerBackpressureThread.start();
+ Thread.sleep(100);
+ WorkerBackpressureThread.notifyBackpressureChecker(trigger);
+ Thread.sleep(100);
+ Assert.assertNotEquals("Check the calling times of backpressure
events, should not be 0. ",
+ workerData.get(), 0);
+ }
+
+ @Test
+ public void testThrowRuntimeExceptionEvent() throws Exception {
+ Object trigger = new Object();
+ Object workerData = new Object();
+ WorkerBackpressureCallback callback = new
WorkerBackpressureCallback() {
+ @Override
+ public void onEvent(Object obj) {
+ throw new RuntimeException();
+ }
+ };
+ WorkerBackpressureThread workerBackpressureThread = new
WorkerBackpressureThread(trigger, workerData, callback);
+ workerBackpressureThread.start();
+ Thread.sleep(100);
+ WorkerBackpressureThread.notifyBackpressureChecker(trigger);
+ Thread.sleep(100);
--- End diff --
I really hate hard coded sleeps in tests. Could we please replace this
with something like
```
workerBackpressureThread.start();
long start = System.currentTimeMillis();
while (!workerBackpressureThread.isAlive()) {
assertTrue("Timeout", (System.currentTimeMillis() - start) <
1000);
Thread.sleep(100);
}
WorkerBackpressureThread.notifyBackpressureChecker(trigger);
long start = System.currentTimeMillis();
while (workerBackpressureThread.isAlive()) {
assertTrue("Timeout", (System.currentTimeMillis() - start) <
1000);
Thread.sleep(100);
}
```
> Better exception handling in backpressure thread, and remove backpressure dir
> during topology kill.
> ---------------------------------------------------------------------------------------------------
>
> Key: STORM-1574
> URL: https://issues.apache.org/jira/browse/STORM-1574
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Fix For: 1.0.0, 2.0.0
>
>
> The current exception handling in WorkerBackpressureThread can cause the
> thread to die before we want, causing potential backpressure flag
> synchronizing problem.
> Also, we need to cleanup the topology backpressure directory during killing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
