[
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167952#comment-15167952
]
ASF GitHub Bot commented on STORM-822:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-189004616
I agree that we need to keep track of outstanding tuples + offsets, and the
code you have around acked feels OK, but we could possibly clean it up a
little. I called it markAsDone instead of addAckedTuples because I didn't
really like having a tuple that failed too many times be marked as acked, but
thinking about it more it is not that big of a deal.
> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to
> reduce dependencies and use long term supported kafka apis
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-822
> URL: https://issues.apache.org/jira/browse/STORM-822
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Hugo Louro
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
