[ 
https://issues.apache.org/jira/browse/STORM-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169768#comment-15169768
 ] 

ASF GitHub Bot commented on STORM-1270:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1156#discussion_r54299455
  
    --- Diff: 
examples/storm-starter/src/jvm/org/apache/storm/starter/ManualDRPC.java ---
    @@ -30,39 +30,37 @@
     import org.apache.storm.tuple.Tuple;
     import org.apache.storm.tuple.Values;
     
    -
     public class ManualDRPC {
    -  public static class ExclamationBolt extends BaseBasicBolt {
    -
    -    @Override
    -    public void declareOutputFields(OutputFieldsDeclarer declarer) {
    -      declarer.declare(new Fields("result", "return-info"));
    -    }
    +    public static class ExclamationBolt extends BaseBasicBolt {
     
    -    @Override
    -    public void execute(Tuple tuple, BasicOutputCollector collector) {
    -      String arg = tuple.getString(0);
    -      Object retInfo = tuple.getValue(1);
    -      collector.emit(new Values(arg + "!!!", retInfo));
    -    }
    +        @Override
    +        public void declareOutputFields(OutputFieldsDeclarer declarer) {
    +            declarer.declare(new Fields("result", "return-info"));
    +        }
     
    -  }
    +        @Override
    +        public void execute(Tuple tuple, BasicOutputCollector collector) {
    +            String arg = tuple.getString(0);
    +            Object retInfo = tuple.getValue(1);
    +            collector.emit(new Values(arg + "!!!", retInfo));
    +        }
     
    -  public static void main(String[] args) {
    -    TopologyBuilder builder = new TopologyBuilder();
    -    LocalDRPC drpc = new LocalDRPC();
    +    }
     
    -    DRPCSpout spout = new DRPCSpout("exclamation", drpc);
    -    builder.setSpout("drpc", spout);
    -    builder.setBolt("exclaim", new ExclamationBolt(), 
3).shuffleGrouping("drpc");
    -    builder.setBolt("return", new ReturnResults(), 
3).shuffleGrouping("exclaim");
    +    public static void main(String[] args) throws Exception{
    +        TopologyBuilder builder = new TopologyBuilder();
    +        LocalDRPC drpc = new LocalDRPC();
     
    -    LocalCluster cluster = new LocalCluster();
    -    Config conf = new Config();
    -    cluster.submitTopology("exclaim", conf, builder.createTopology());
    +        DRPCSpout spout = new DRPCSpout("exclamation", drpc);
    +        builder.setSpout("drpc", spout);
    +        builder.setBolt("exclaim", new ExclamationBolt(), 
3).shuffleGrouping("drpc");
    +        builder.setBolt("return", new ReturnResults(), 
3).shuffleGrouping("exclaim");
     
    -    System.out.println(drpc.execute("exclamation", "aaa"));
    -    System.out.println(drpc.execute("exclamation", "bbb"));
    +        LocalCluster cluster = new LocalCluster();
    +        Config conf = new Config();
    +        cluster.submitTopology("exclaim", conf, builder.createTopology());
     
    -  }
    +        System.out.println(drpc.execute("exclamation", "aaa"));
    +        System.out.println(drpc.execute("exclamation", "bbb"));
    +    }
     }
    --- End diff --
    
    Please don't change the spacing/formatting for files you didn't touch 
otherwise.


> port backtype.storm.daemon.drpc to java
> ---------------------------------------
>
>                 Key: STORM-1270
>                 URL: https://issues.apache.org/jira/browse/STORM-1270
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: John Fang
>              Labels: java-migration, jstorm-merger
>
> DRPC server with HTTP and thrift support
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/drpc/Drpc.java
> (But missing HTTP support)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to