[
https://issues.apache.org/jira/browse/STORM-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171525#comment-15171525
]
ASF GitHub Bot commented on STORM-1552:
---------------------------------------
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1161#issuecomment-190074820
I suspected that the logs directory is being created inside the project
itself and failing rat check. I pulled in your changes to check the same.
```find storm-core/storm-local/logs -type f | wc -l
26
```
This directory is not excluded from the RAT check and thus build is
failing. can you try excluding this directory from RAT check and run the build
on your local end (mvn clean install) to see if the build succeeds?
Sorry to tell this late but I see a problem with these changes I didn't
think of before. Earlier the default log location was under logs directory.
With these changes, logs will start going in storm-local directory which is
meant for internal use. logs directory becomes redundant since storm.loca.dir
always has a default value. In fact this PR will break STORM-1552 which
@arunmahadevan should confirm.
The exceptions in test classes may be fixed without changing the getLogDir
implementation (by passing the `storm.local.dir/logs` as storm.log.dir property
value instead of hardcoded logs directory)
> Fix topology event sampling log directory
> ------------------------------------------
>
> Key: STORM-1552
> URL: https://issues.apache.org/jira/browse/STORM-1552
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
> Fix For: 1.0.0
>
>
> Run a topology and enable event inspection by clicking "Debug" from UI. The
> events are logged under
> "storm-local/workers-artifacts/{storm-id}/port/events.log". In the spout/bolt
> details page, the "events" link does not display the log file.
> The events.log should be kept under
> logs/workers-artifacts/{storm-id}/{port}/events.log so that its viewable via
> logviewer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
