Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-190345957
For the most part things look good. My biggest concern is around catching
Exception and ignoring it when we commit offsets.
I am also a little concerned about having auto-commit be the default, as it
violates some of storms guarantees. I would prefer it to honor storms
guarantees by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
