GitHub user dsimmons opened a pull request:

    https://github.com/apache/storm/pull/1168

    Fixed incorrect storm-kafka documentation.

    Removed an incorrect (outdated?) constructor of `SpoutConfig` from the 
README.
    
    Just threw me for a quick loop until I [looked at the 
source](https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/SpoutConfig.java#L41)
 and confirmed that, sure enough, `zkRoot` isn't optional (the constructor 
isn't ***actually*** overloaded like the README claims).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dsimmons/storm fix/incorrect-documentation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1168
    
----
commit 3f5d3b363a5546eb7ac4d8cadbb9136cbc8e553d
Author: Dan Simmons <[email protected]>
Date:   2016-02-29T20:08:22Z

    Fixed incorrect storm-kafka documentation.
    
    Removed an incorrect (outdated?) optional constructor of `SpoutConfig` from 
the README.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to