Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1174#discussion_r54730661
  
    --- Diff: storm-core/src/jvm/org/apache/storm/task/OutputCollector.java ---
    @@ -218,6 +218,16 @@ public void fail(Tuple input) {
             _delegate.fail(input);
         }
     
    +    /**
    +    * Resets the message timeout for any tuple trees to which the given 
tuple belongs.
    +    * The timeout is reset to Config.TOPOLOGY_MESSAGE_TIMEOUT_SECS.
    +    * @param input the tuple to reset timeout for
    +    */
    --- End diff --
    
    Can we add to the javadoc that this should be used sparingly?  This is not 
a cheap operation, so having someone do it for each tuple they receive is very 
expensive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to