Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1161#discussion_r54755980
  
    --- Diff: pom.xml ---
    @@ -914,6 +916,26 @@
                     </plugin>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
    +                    <artifactId>maven-antrun-plugin</artifactId>
    +                    <version>1.8</version>
    +                    <executions>
    +                        <execution>
    +                            <phase>install</phase>
    +                            <goals>
    +                                <goal>run</goal>
    +                            </goals>
    +                            <configuration>
    +                                <tasks>
    +                                    <delete quiet="true" 
includeEmptyDirs="true" failonerror="false">
    +                                        <fileset dir="logs"/>
    +                                    </delete>
    +                                </tasks>
    +                            </configuration>
    +                        </execution>
    +                    </executions>
    +                </plugin>
    --- End diff --
    
    I have had a lot of issues in the past with trying to use antrun to clean.  
I really would prefer to change it to be something like
    
    ```
                <plugin>
                    <artifactId>maven-clean-plugin</artifactId>
                    <version>2.5</version>
                    <executions>
                        <execution>
                            <id>cleanup</id>
                            <phase>clean</phase>
                            <goals>
                                <goal>clean</goal>
                            </goals>
                            <configuration>
                                
<excludeDefaultDirectories>true</excludeDefaultDirectories>
                                <filesets>
                                    <fileset>
                                        <directory>./logs/</directory>
                                    </fileset>
                                </filesets>
                            </configuration>
                        </execution>
                    </executions>
                </plugin>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to