[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176238#comment-15176238
 ] 

ASF GitHub Bot commented on STORM-822:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1131#discussion_r54770496
  
    --- Diff: external/storm-kafka-new-consumer-api/pom.xml ---
    @@ -0,0 +1,91 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--/**
    +        * Licensed to the Apache Software Foundation (ASF) under one
    +        * or more contributor license agreements.  See the NOTICE file
    +        * distributed with this work for additional information
    +        * regarding copyright ownership.  The ASF licenses this file
    +        * to you under the Apache License, Version 2.0 (the
    +        * "License"); you may not use this file except in compliance
    +        * with the License.  You may obtain a copy of the License at
    +        *
    +        * http://www.apache.org/licenses/LICENSE-2.0
    +        *
    +        * Unless required by applicable law or agreed to in writing, 
software
    +        * distributed under the License is distributed on an "AS IS" BASIS,
    +        * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +        * See the License for the specific language governing permissions 
and
    +        * limitations under the License.
    +        */-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <artifactId>storm</artifactId>
    +        <groupId>org.apache.storm</groupId>
    +        <version>2.0.0-SNAPSHOT</version>
    +        <relativePath>../../pom.xml</relativePath>
    +    </parent>
    +
    +    <artifactId>storm-kafka-new-consumer-api</artifactId>
    +    <name>storm-kafka-new-consumer-api</name>
    +
    +    <packaging>jar</packaging>
    +
    +    <developers>
    +        <developer>
    +            <id>hmcl</id>
    +            <name>Hugo Louro</name>
    +            <email>hmclo...@gmail.com</email>
    +        </developer>
    +    </developers>
    +
    +    <dependencies>
    +        <!--parent module dependency-->
    +        <dependency>
    +            <groupId>org.apache.storm</groupId>
    +            <artifactId>storm-core</artifactId>
    +            <version>${project.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <!--kafka libraries-->
    +        <dependency>
    +            <groupId>org.apache.kafka</groupId>
    +            <artifactId>${kafka.artifact.id}</artifactId>
    +            <scope>provided</scope>
    +        </dependency>
    --- End diff --
    
    This package is not actually used by the spout at all.  We can remove it 
and everything still compiles.  Why is it needed?


> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to 
> reduce dependencies and use long term supported kafka apis 
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-822
>                 URL: https://issues.apache.org/jira/browse/STORM-822
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Hugo Louro
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)