Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r55037499
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.serialization;
+
+import com.google.common.collect.Lists;
+import org.apache.storm.Config;
+import org.apache.storm.testing.TestSerObject;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class SerializationTest {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SerializationTest.class);
+
+ @Test
+ public void testJavaSerialization() {
+ Object obj = new TestSerObject(1, 2);
+ List<Object> vals = Lists.newArrayList(obj);
+
+ Map<String, Object> conf = new HashMap<>();
+ conf.put(Config.TOPOLOGY_KRYO_REGISTER, new HashMap<String,
String>() {{
+ put("org.apache.storm.testing.TestSerObject", null);
+ }});
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, false);
+ try {
+ roundtrip(vals, conf);
+ Assert.fail("Expected Exception not Thrown for config: " +
conf);
+ } catch (Exception e) {
+ }
+
+ conf.clear();
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, true);
+ Assert.assertEquals(vals, roundtrip(vals, conf));
+ }
+
+ @Test
+ public void testKryoDecorator() {
+ Object obj = new TestSerObject(1, 2);
+ List<Object> vals = Lists.newArrayList(obj);
+
+ Map<String, Object> conf = new HashMap<>();
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, false);
+ try {
+ roundtrip(vals, conf);
+ Assert.fail("Expected Exception not Thrown for config: " +
conf);
+ } catch (Exception e) {
+ }
+
+ conf.put(Config.TOPOLOGY_KRYO_DECORATORS,
Lists.newArrayList("org.apache.storm.testing.TestKryoDecorator"));
+ Assert.assertEquals(vals, roundtrip(vals, conf));
+ }
+
+ @Test
+ public void testStringSerialization() {
+ isRoundtrip(Lists.newArrayList("a", "bb", "cbe"));
+ isRoundtrip(Lists.newArrayList(mkString(64 * 1024)));
+ isRoundtrip(Lists.newArrayList(mkString(1024 * 1024)));
+ isRoundtrip(Lists.newArrayList(mkString(1024 * 1024 * 2)));
+ }
+
+ private Map mkConf(Map extra) {
+ Map config = Utils.readDefaultConfig();
+ config.putAll(extra);
+ return config;
+ }
+
+ private byte[] serialize(List vals, Map conf) throws IOException {
+ KryoValuesSerializer serializer = new
KryoValuesSerializer(mkConf(conf));
+ return serializer.serialize(vals);
+ }
+
+ private List deserialize(byte[] bytes, Map conf) throws IOException {
+ KryoValuesDeserializer deserializer = new
KryoValuesDeserializer(mkConf(conf));
+ return deserializer.deserialize(bytes);
+ }
+
+ private List roundtrip(List vals) {
+ return roundtrip(vals, new HashMap());
+ }
+
+ private List roundtrip(List vals, Map conf) {
+ List ret = null;
+ try {
+ ret = deserialize(serialize(vals, conf), conf);
+ } catch (IOException e) {
--- End diff --
I would prefer to have the IOException thrown by roundtrip. Catching it
will still cause the test to fail, but it will be harder to debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
