Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1185#discussion_r55285470
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -536,17 +536,17 @@
(throw (RuntimeException. (str "Fatal
error, mismatched task ids: " task-id " " stored-task-id))))
(let [time-delta (if start-time-ms
(Time/deltaMs start-time-ms))]
(condp = stream-id
- ACKER-ACK-STREAM-ID (ack-spout-msg
executor-data (get task-datas task-id)
+ StormCommon/ACKER_ACK_STREAM_ID
(ack-spout-msg executor-data (get task-datas task-id)
spout-id tuple-finished-info time-delta id)
- ACKER-FAIL-STREAM-ID (fail-spout-msg
executor-data (get task-datas task-id)
+ StormCommon/ACKER_FAIL_STREAM_ID
(fail-spout-msg executor-data (get task-datas task-id)
spout-id tuple-finished-info time-delta "FAIL-STREAM" id)
)))
;; TODO: on failure, emit tuple to failure
stream
))))
receive-queue (:receive-queue executor-data)
event-handler (mk-task-receiver executor-data tuple-action-fn)
- has-ackers? (has-ackers? storm-conf)
- has-eventloggers? (has-eventloggers? storm-conf)
+ has-ackers? (clojurify-structure (StormCommon/hasAckers
storm-conf))
+ has-eventloggers? (clojurify-structure
(StormCommon/hasEventLoggers storm-conf))
--- End diff --
I don't think these should need the `clojurify-structure` calls. Were you
seeing errors without it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
