Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55316972
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -240,8 +290,8 @@ public static Subject populateSubject(Subject subject,
Collection<IAutoCredentia
* @param credentials the credentials to pull from
*/
public static void updateSubject(Subject subject,
Collection<IAutoCredentials> autos, Map<String,String> credentials) {
- if (subject == null) {
- throw new RuntimeException("The subject cannot be null when
updating a subject with credentials");
+ if (subject == null || autos == null) {
+ throw new RuntimeException("Both subject and auto credentials
cannot be null when updating a subject with credentials");
--- End diff --
Minor. "The subject or auto credentials.."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
