[
https://issues.apache.org/jira/browse/STORM-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184411#comment-15184411
]
ASF GitHub Bot commented on STORM-1233:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55316972
--- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java
---
@@ -240,8 +290,8 @@ public static Subject populateSubject(Subject subject,
Collection<IAutoCredentia
* @param credentials the credentials to pull from
*/
public static void updateSubject(Subject subject,
Collection<IAutoCredentials> autos, Map<String,String> credentials) {
- if (subject == null) {
- throw new RuntimeException("The subject cannot be null when
updating a subject with credentials");
+ if (subject == null || autos == null) {
+ throw new RuntimeException("Both subject and auto credentials
cannot be null when updating a subject with credentials");
--- End diff --
Minor. "The subject or auto credentials.."
> port backtype.storm.security.auth.AuthUtils-test to java
> --------------------------------------------------------
>
> Key: STORM-1233
> URL: https://issues.apache.org/jira/browse/STORM-1233
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Alessandro Bellina
> Labels: java-migration, jstorm-merger
>
> Just a test moving to junit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)