[ 
https://issues.apache.org/jira/browse/STORM-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185983#comment-15185983
 ] 

ASF GitHub Bot commented on STORM-1609:
---------------------------------------

Github user redsanket commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1194#discussion_r55441072
  
    --- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java 
---
    @@ -108,6 +110,13 @@
         private final AtomicInteger messagesLost = new AtomicInteger(0);
     
         /**
    +     * Periodically checks for connected channel in order to avoid loss
    +     * of messages
    +     */
    +    private final long CHANNEL_ALIVE_INTERVAL_MS = 30000L;
    +
    --- End diff --
    
    fixed


> Netty Client is not best effort delivery on failed Connection
> -------------------------------------------------------------
>
>                 Key: STORM-1609
>                 URL: https://issues.apache.org/jira/browse/STORM-1609
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Sanket Reddy
>            Assignee: Sanket Reddy
>
> f Worker-A has connection to Worker-B that is unused ( and if Worker-B 
> restarted), we drop messages because Channel is not in good state. Can we 
> avoid message drop until we succeed in making new connection or a timeout?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to