[ 
https://issues.apache.org/jira/browse/STORM-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187235#comment-15187235
 ] 

ASF GitHub Bot commented on STORM-1608:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/1190#issuecomment-194341881
  
    @arunmahadevan Thanks for doing this.  I still have not had time to dig 
into this feature in as much detail as I would like, but from what I have seen 
so far the contract with users looks good, and it is an important feature to 
have.  I have one concern now about thread safety in the 
AckTrackingOutputCollector, but beyond that it looks fine.
    
    I will leave support for best effort state checkpointing without at least 
once processing for a later time.  Like I said before I made an assumption that 
was wrong, and that was part of why I got confused.  I don't see it as a must 
have feature, just confusion on my part.


> Fix stateful topology acking behavior
> -------------------------------------
>
>                 Key: STORM-1608
>                 URL: https://issues.apache.org/jira/browse/STORM-1608
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>
> Right now the acking is automatically taken care of for the non-stateful 
> bolts in a stateful topology. This leads to double acking if BaseRichBolts 
> are part of the topology. For the non-stateful bolts, its better to let the 
> bolt do the acking rather than automatically acking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to