[
https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189680#comment-15189680
]
ASF GitHub Bot commented on STORM-1616:
---------------------------------------
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55725427
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -409,16 +427,26 @@ public StormTopology build() {
throw new RuntimeException("Regular rich spouts not
supported yet... try wrapping in a RichSpoutBatchExecutor");
// TODO: handle regular rich spout without batches
(need lots of updates to support this throughout)
}
- builder.setSpout(spoutIds.get(sn), sn.streamId, sn.txId,
s, parallelism, batchGroupMap.get(sn));
+ builder.setSpout(spoutIds.get(sn), sn.streamId, sn.txId,
s, parallelism, batchGroupMap.get(sn))
+ .setMemoryLoad(onHeap, offHeap)
+ .setCPULoad(cpuLoad);
}
}
-
+
for(Group g: mergedGroups) {
--- End diff --
can we use a different variable name then "g"? The name was kind of
confusing we I was looking through the code
> Add RAS API for Trident
> -----------------------
>
> Key: STORM-1616
> URL: https://issues.apache.org/jira/browse/STORM-1616
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
