Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55725427
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -409,16 +427,26 @@ public StormTopology build() {
throw new RuntimeException("Regular rich spouts not
supported yet... try wrapping in a RichSpoutBatchExecutor");
// TODO: handle regular rich spout without batches
(need lots of updates to support this throughout)
}
- builder.setSpout(spoutIds.get(sn), sn.streamId, sn.txId,
s, parallelism, batchGroupMap.get(sn));
+ builder.setSpout(spoutIds.get(sn), sn.streamId, sn.txId,
s, parallelism, batchGroupMap.get(sn))
+ .setMemoryLoad(onHeap, offHeap)
+ .setCPULoad(cpuLoad);
}
}
-
+
for(Group g: mergedGroups) {
--- End diff --
can we use a different variable name then "g"? The name was kind of
confusing we I was looking through the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
