Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r55732854 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java --- @@ -0,0 +1,273 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.daemon.supervisor; + +import org.apache.commons.lang.StringUtils; +import org.apache.curator.utils.PathUtils; +import org.apache.storm.Config; +import org.apache.storm.generated.LSWorkerHeartbeat; +import org.apache.storm.localizer.LocalResource; +import org.apache.storm.localizer.Localizer; +import org.apache.storm.utils.ConfigUtils; +import org.apache.storm.utils.LocalState; +import org.apache.storm.utils.Utils; +import org.apache.zookeeper.ZooDefs; +import org.apache.zookeeper.data.ACL; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; +import java.io.IOException; +import java.net.URLDecoder; +import java.util.*; + +public class SupervisorUtils { + + private static final Logger LOG = LoggerFactory.getLogger(SupervisorUtils.class); + + private static final SupervisorUtils INSTANCE = new SupervisorUtils(); + private static SupervisorUtils _instance = INSTANCE; + + public static void setInstance(SupervisorUtils u) { + _instance = u; + } + + public static void resetInstance() { + _instance = INSTANCE; + } + + public static Process workerLauncher(Map conf, String user, List<String> args, Map<String, String> environment, final String logPreFix, --- End diff -- Thank you for the clarification. runAsUser sounds like a good name for this API. It is also possible to always pass user in the API signatures. If SUPERVISOR_WORKER_LAUNCHER is not enabled, the user argument will be local user and ignored in the implementation. Otherwise, commands will be launched with that user's permission. The implementation can be prepared when supervisor starts up.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---