Github user abellina commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1202#discussion_r55769202
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -738,6 +738,7 @@
                         (run-worker-shutdown-hooks worker)
     
                         (.removeWorkerHeartbeat (:storm-cluster-state worker) 
storm-id assignment-id (long port))
    +                    (.removeWorkerBackpressure (:storm-cluster-state 
worker) storm-id assignment-id (long port))
    --- End diff --
    
    I tested submiting topologies and killing them and did not see issues do to 
this added line, but to those with more knowledge of backpressure logic please 
let me know if you can think of issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to