[ 
https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192374#comment-15192374
 ] 

ASF GitHub Bot commented on STORM-1279:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1184#discussion_r55938170
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
    @@ -0,0 +1,178 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.daemon.supervisor;
    +
    +import org.apache.commons.io.FileUtils;
    +import org.apache.storm.Config;
    +import org.apache.storm.StormTimer;
    +import org.apache.storm.daemon.supervisor.timer.RunProfilerActions;
    +import org.apache.storm.daemon.supervisor.timer.SupervisorHealthCheck;
    +import org.apache.storm.daemon.supervisor.timer.SupervisorHeartbeat;
    +import org.apache.storm.daemon.supervisor.timer.UpdateBlobs;
    +import org.apache.storm.event.EventManagerImp;
    +import org.apache.storm.localizer.Localizer;
    +import org.apache.storm.messaging.IContext;
    +import org.apache.storm.metric.StormMetricsRegistry;
    +import org.apache.storm.scheduler.ISupervisor;
    +import org.apache.storm.utils.ConfigUtils;
    +import org.apache.storm.utils.Utils;
    +import org.apache.storm.utils.VersionInfo;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +import java.io.InterruptedIOException;
    +import java.util.Collection;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.concurrent.Callable;
    +
    +public class Supervisor {
    +    private static Logger LOG = LoggerFactory.getLogger(Supervisor.class);
    +
    +    // TODO: to be removed after porting worker.clj. localSyncProcess is 
intended to start local supervisor
    +    private SyncProcessEvent localSyncProcess;
    +
    +    public void setLocalSyncProcess(SyncProcessEvent localSyncProcess) {
    +        this.localSyncProcess = localSyncProcess;
    +    }
    +
    +    /**
    +     * in local state, supervisor stores who its current assignments are 
another thread launches events to restart any dead processes if necessary
    +     * 
    +     * @param conf
    +     * @param sharedContext
    +     * @param iSupervisor
    +     * @return
    +     * @throws Exception
    +     */
    +    public SupervisorManger mkSupervisor(final Map conf, IContext 
sharedContext, ISupervisor iSupervisor) throws Exception {
    +        SupervisorManger supervisorManger = null;
    +        try {
    +            LOG.info("Starting Supervisor with conf {}", conf);
    +            iSupervisor.prepare(conf, 
ConfigUtils.supervisorIsupervisorDir(conf));
    +            String path = ConfigUtils.supervisorTmpDir(conf);
    +            FileUtils.cleanDirectory(new File(path));
    +
    +            final SupervisorData supervisorData = new SupervisorData(conf, 
sharedContext, iSupervisor);
    +            Localizer localizer = supervisorData.getLocalizer();
    +
    +            SupervisorHeartbeat hb = new SupervisorHeartbeat(conf, 
supervisorData);
    +            hb.run();
    +            // should synchronize supervisor so it doesn't launch anything 
after being down (optimization)
    +            Integer heartbeatFrequency = 
Utils.getInt(conf.get(Config.SUPERVISOR_HEARTBEAT_FREQUENCY_SECS));
    +            supervisorData.getHeartbeatTimer().scheduleRecurring(0, 
heartbeatFrequency, hb);
    +
    +            Set<String> downdedStormId = 
SupervisorUtils.readDownLoadedStormIds(conf);
    --- End diff --
    
    nit. downloadedStormIds


> port backtype.storm.daemon.supervisor to java
> ---------------------------------------------
>
>                 Key: STORM-1279
>                 URL: https://issues.apache.org/jira/browse/STORM-1279
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: John Fang
>              Labels: java-migration, jstorm-merger
>         Attachments: Discussion about supervisor.pdf
>
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/daemon/supervisor
>  as an example
> backtype.storm.event usage should be replaced with built-in java threadpools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to