[ 
https://issues.apache.org/jira/browse/STORM-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192883#comment-15192883
 ] 

ASF GitHub Bot commented on STORM-1464:
---------------------------------------

Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1044#discussion_r55965843
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
 ---
    @@ -145,13 +134,20 @@ public final void execute(Tuple tuple) {
     
             synchronized (this.writeLock) {
                 boolean forceSync = false;
    +            AbstractHDFSWriter writer = null;
    +            String writerKey = null;
    +
                 if (TupleUtils.isTick(tuple)) {
                     LOG.debug("TICK! forcing a file system flush");
                     this.collector.ack(tuple);
                     forceSync = true;
                 } else {
    +
    +                writerKey = getHashKeyForTuple(tuple);
    --- End diff --
    
    Can't the partition path be used as the key?


> storm-hdfs should support writing to multiple files
> ---------------------------------------------------
>
>                 Key: STORM-1464
>                 URL: https://issues.apache.org/jira/browse/STORM-1464
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-hdfs
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>              Labels: avro
>
> Examples of when this is needed include:
> - One avro bolt writing multiple schemas, each of which require a different 
> file. Schema evolution is a common use of avro and the avro bolt should 
> support that seamlessly.
> - Partitioning output to different directories based on the tuple contents.  
> For example, if the tuple contains a "USER" field, it should be possible to 
> partition based on that value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to