GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1214
STORM-1629 Files/move doesn't work properly with non-empty directory in
Windows
Please refer https://issues.apache.org/jira/browse/STORM-1629 to see why
Files/move with non-empty directory fails on Windows.
* Use FileUtils/moveDirectory on Windows
* It copies whole contents inside directory, and delete directory
* Keep using Files/move on non-Windows
* it's still better option since doesn't require copying contents inside
directory
Since `on-windows?` is ported to Java, I'll create separate pull request
for 1.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1214
----
commit 02f9308d80da67b6da634b96a08e169268bd9262
Author: Jungtaek Lim <[email protected]>
Date: 2016-03-15T15:06:58Z
STORM-1629 Files/move doesn't work properly with non-empty directory in
Windows
* Use FileUtils/moveDirectory on Windows
* It copies whole contents inside directory, and delete directory
* Keep using Files/move on non-Windows
* it's still better option since doesn't require copying contents inside
directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
