[
https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196954#comment-15196954
]
ASF GitHub Bot commented on STORM-1268:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1218#discussion_r56292345
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/metrics/BuiltinMetricsUtil.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.metrics;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.storm.Config;
+import org.apache.storm.metric.api.IMetric;
+import org.apache.storm.metric.api.IStatefulObject;
+import org.apache.storm.metric.api.StateMetric;
+import org.apache.storm.stats.BoltExecutorStats;
+import org.apache.storm.stats.SpoutExecutorStats;
+import org.apache.storm.stats.StatsUtil;
+import org.apache.storm.task.TopologyContext;
+
+public class BuiltinMetricsUtil {
+ public static BuiltinMetrics mkData(String type, Object stats) {
+ if (StatsUtil.SPOUT.equals(type)) {
+ return new BuiltinSpoutMetrics((SpoutExecutorStats) stats);
+ }
+ return new BuiltinBoltMetrics((BoltExecutorStats) stats);
--- End diff --
just to be safer, can you also check that type is equal to Bolt in the else
block
> port backtype.storm.daemon.builtin-metrics to java
> --------------------------------------------------
>
> Key: STORM-1268
> URL: https://issues.apache.org/jira/browse/STORM-1268
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Cody
> Labels: java-migration, jstorm-merger
>
> Built-in metrics
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
