[ 
https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198492#comment-15198492
 ] 

ASF GitHub Bot commented on STORM-1616:
---------------------------------------

Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1199#discussion_r56440695
  
    --- Diff: storm-core/src/jvm/org/apache/storm/trident/graph/Group.java ---
    @@ -65,6 +68,25 @@ public Group(Group g1, Group g2) {
         }
     
         @Override
    +    public Map<String, Number> getResources() {
    +        Map<String, Number> ret = new HashMap<>();
    +        for(Node n: nodes) {
    +            if(n instanceof ITridentResource) {
    +                Map<String, Number> res = 
((ITridentResource)n).getResources();
    --- End diff --
    
    minor: n is always an instance of `ITridentResource`, no need of if check 
and type casting.


> Add RAS API for Trident
> -----------------------
>
>                 Key: STORM-1616
>                 URL: https://issues.apache.org/jira/browse/STORM-1616
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to