Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1199#discussion_r56440695
  
    --- Diff: storm-core/src/jvm/org/apache/storm/trident/graph/Group.java ---
    @@ -65,6 +68,25 @@ public Group(Group g1, Group g2) {
         }
     
         @Override
    +    public Map<String, Number> getResources() {
    +        Map<String, Number> ret = new HashMap<>();
    +        for(Node n: nodes) {
    +            if(n instanceof ITridentResource) {
    +                Map<String, Number> res = 
((ITridentResource)n).getResources();
    --- End diff --
    
    minor: n is always an instance of `ITridentResource`, no need of if check 
and type casting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to