[
https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209653#comment-15209653
]
ASF GitHub Bot commented on STORM-1654:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1251
STORM-1654 HBaseBolt creates tick tuples with no interval when we don't set
flushIntervalSecs
Please also refer #893 to see why this change is necessary.
Set 'default' flush interval seconds to HBaseBolt, since taking half of
message timeout secs doesn't work, as #893 showed.
Since we should hardcode default flush interval seconds for now, I think we
can change default flush interval to 1s since I guess it's enough for HBase,
and anyone never set up tuple timeout seconds to 1. (When if this is happening,
all bolts with batching manner using tick tuple should also fail.)
I'll craft separate PR to be applied to 1.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1654
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1251
----
commit c6ed8d0c419dba8bdb479a432d5e7855f78b012b
Author: Jungtaek Lim <[email protected]>
Date: 2016-03-24T02:57:28Z
STORM-1654 HBaseBolt creates tick tuples with no interval when we don't set
flushIntervalSecs
* set 'default' flush interval seconds (1s) to HBaseBolt
* since taking half of message timeout secs doesn't work
----
> HBaseBolt creates tick tuples with no interval when we don't set
> flushIntervalSecs
> ------------------------------------------------------------------------------------
>
> Key: STORM-1654
> URL: https://issues.apache.org/jira/browse/STORM-1654
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hbase
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> As STORM-1219 addressed, we can't get value about topology's message timeout
> seconds at getComponentConfiguration(), so logic for applying flush interval
> to the half of message timeout is no effect.
> Unless we set flushIntervalSeconds explicitly, tick tuple interval is set to
> 0 second, no interval.
> Other bolts were fixed as STORM-1219, but seems missing HBaseBolt.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
