[
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209771#comment-15209771
]
ASF GitHub Bot commented on STORM-1632:
---------------------------------------
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-200669173
@roshannaik did you try passing the map values are arguments and take the
measurements? Based on your earlier results it appeared that PersistentMap
lookup was causing the hit (I still think it could very well be due to the
profiler overhead)
Here are the changes I made -
https://github.com/arunmahadevan/storm/commit/7eae5ec9f63cee82c49980a3bedf5f0dfe4e3a8d
. I would like see how it affects your profiling.
I don't think a 0.4 to 0.5 % increase in throughput should be a reason to
completely disable a feature. And spouts that emit tuples in a tight loop would
not be a very common use case whatsoever. I am for documenting this feature so
that the users can adjust the config values based on their needs rather than
turning it off.
> Disable event logging by default
> --------------------------------
>
> Key: STORM-1632
> URL: https://issues.apache.org/jira/browse/STORM-1632
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Priority: Blocker
> Fix For: 1.0.0
>
>
> EventLogging has performance penalty. For a simple speed of light topology
> with a single instances of a spout and a bolt, disabling event logging
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off
> by default.
> **Update:** with acker=0 the observed impact was much higher... **25%**
> faster when event loggers = 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
