GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1253

    STORM-1655 Flux doesn't set return code to non-zero when there's any 
exception while deploying topology to remote cluster

    * Modify Flux.runCli() to not catching exceptions so that exception can be 
propagated to main()
    
    JVM sets exit code to 1 when exception is propagated to main() and even 
main() doesn't catch it.
    
    ```
    ...
    606  [main] INFO  o.a.s.f.Flux - Running remotely...
    606  [main] INFO  o.a.s.f.Flux - Deploying topology in an ACTIVE state...
    619  [main] INFO  o.a.s.StormSubmitter - Generated ZooKeeper secret payload 
for MD5-digest: -5653047561138062924:-4997865894002296638
    669  [main] INFO  o.a.s.s.a.AuthUtils - Got AutoCreds []
    Exception in thread "main" java.lang.RuntimeException: Topology with name 
`yaml-topology` already exists on cluster
        at 
org.apache.storm.StormSubmitter.submitTopologyAs(StormSubmitter.java:230)
        at 
org.apache.storm.StormSubmitter.submitTopology(StormSubmitter.java:288)
        at org.apache.storm.flux.Flux.runCli(Flux.java:171)
        at org.apache.storm.flux.Flux.main(Flux.java:98)
     > echo $?
    1
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-1655

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1253
    
----
commit ba2385882e705ebf5c33f5a03b67dc3b14781460
Author: Jungtaek Lim <[email protected]>
Date:   2016-03-24T07:45:24Z

    STORM-1655 Flux doesn't set return code to non-zero when there's any 
exception while deploying topology to remote cluster
    
    * Modify Flux.runCli() to not catching exceptions so that exception can be 
propagated to main()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to