[
https://issues.apache.org/jira/browse/STORM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209927#comment-15209927
]
ASF GitHub Bot commented on STORM-1655:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1254
STORM-1655 (1.x) Flux doesn't set return code to non-zero when there's any
exception while deploying topology to remote cluster
* Modify Flux.runCli() to not catching exceptions so that exception can be
propagated to main()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1655-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1254
----
commit 723b08735192895b4a8972c0a8b1a49bb7aae33f
Author: Jungtaek Lim <[email protected]>
Date: 2016-03-24T07:45:24Z
STORM-1655 Flux doesn't set return code to non-zero when there's any
exception while deploying topology to remote cluster
* Modify Flux.runCli() to not catching exceptions so that exception can be
propagated to main()
----
> Flux doesn't set return code to non-zero when there's any exception while
> deploying topology to remote cluster
> --------------------------------------------------------------------------------------------------------------
>
> Key: STORM-1655
> URL: https://issues.apache.org/jira/browse/STORM-1655
> Project: Apache Storm
> Issue Type: Bug
> Components: Flux
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Minor
>
> Flux.runCli() swallows any Exceptions when deploying topology remotely, while
> StormSubmitter.submitTopology() can throw exceptions.
> (AlreadyAliveException, InvalidTopologyException, AuthorizationException, and
> so on)
> It just prints warning log, and return code is 0, not non-zero.
> You can easily reproduce via deploying same topology twice with Flux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
