[ 
https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210958#comment-15210958
 ] 

ASF GitHub Bot commented on STORM-1300:
---------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1232#discussion_r57388639
  
    --- Diff: 
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
 ---
    @@ -285,4 +288,72 @@ public static TopologyDetails 
findTopologyInSetFromName(String topoName, Set<Top
             }
             return ret;
         }
    +
    +    public static Map<SupervisorDetails, Double> 
getSupervisorToMemoryUsage(Cluster cluster, Topologies topologies) {
    --- End diff --
    
    This method and getSupervisorToCpuUsage are almost exactly identical. Can 
you combine them to reduce duplicate code?


> port  backtype.storm.scheduler.resource-aware-scheduler-test to java
> --------------------------------------------------------------------
>
>                 Key: STORM-1300
>                 URL: https://issues.apache.org/jira/browse/STORM-1300
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Zhuo Liu
>              Labels: java-migration, jstorm-merger
>
> Test RAS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to