[
https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218453#comment-15218453
]
ASF GitHub Bot commented on STORM-1279:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57933384
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/workermanager/IWorkerManager.java
---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon.supervisor.workermanager;
+
+import org.apache.storm.generated.WorkerResources;
+import org.apache.storm.localizer.Localizer;
+import org.apache.storm.utils.Utils;
+
+import java.util.List;
+import java.util.Map;
+
+public interface IWorkerManager {
+ public void prepareWorker(Map conf, Localizer localizer);
+
+ IWorkerResult launchWorker(String supervisorId, String assignmentId,
String stormId, Long port, String workerId, WorkerResources resources,
+ Utils.ExitCodeCallable workerExitCallback);
+
+ IWorkerResult shutdownWorker(String supervisorId, String workerId,
Map<String, String> workerThreadPids);
+
+ IWorkerResult resizeWorker(String supervisorId, String assignmentId,
String stormId, Long port, String workerId, WorkerResources resources);
+
+ public boolean cleanupWorker(String workerId);
+}
--- End diff --
All of this was intended to be an example of what we might want to do.
IWorkerReasult is never used and is always returned as null, so lets just set
the return types to be void for now and remove IWorkerResult. resizeWorker is
also not used/supported so lets just delete it for now.
> port backtype.storm.daemon.supervisor to java
> ---------------------------------------------
>
> Key: STORM-1279
> URL: https://issues.apache.org/jira/browse/STORM-1279
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: John Fang
> Labels: java-migration, jstorm-merger
> Attachments: Discussion about supervisor.pdf
>
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/daemon/supervisor
> as an example
> backtype.storm.event usage should be replaced with built-in java threadpools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
