Github user sachingsachin commented on the pull request:

    https://github.com/apache/storm/pull/1287#issuecomment-204216287
  
    Very useful observation @moesol 
    Comparing the 
[KafkaConfig.java](https://github.com/apache/storm/blob/a4f9f8bc5b4ca85de487a0a868e519ddcb94e852/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaConfig.java)
 and [Kafka Configuration](https://kafka.apache.org/08/configuration.html), it 
seems several other useful configurations like socket.timeout.ms, 
rebalance.max.retries etc. are also absent from KafkaConfig.java
    
    We should probably add most (if not all) of these options to our 
spout-configuration.
    
    If we agree that it's useful, then we can add the remaining configuration 
options to this pull request OR I can submit a new one for the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to