I am -0 on releasing with a failing test, especially with a fix in hand. On 4/4/16, 10:50 AM, "P. Taylor Goetz" <[email protected]> wrote:
>The question at this point is whether we want to cancel the release vote >and cut a new RC, or move forward with this one. > >I don’t see the test issue as critical ― users will still be able to >build the software with the `-DskipTests=true` flag. I also feel that >once the 1.0 release is out we will go into a phase where we release >updates (e.g. 1.0.x, 1.x) at a relatively rapid rate. > >I could go either way. What does everyone else think? > >-Taylor > > >> On Apr 2, 2016, at 10:51 PM, Harsha <[email protected]> wrote: >> >> For rc2 please include STORM-1670 as well. Source distribution is >> important as well. >> -Harsha >> >> On Sat, Apr 2, 2016, at 01:02 AM, Jungtaek Lim wrote: >>> Here's my test, >>> >>> - testing with source distribution : FAIL >>> - unzip : OK >>> - building from source dist : FAIL >>> - how to build: running `mvn -P all-tests clean install` on unzipped >>> source dist. >>> - Test resource files (.log) are excluded from source distribution, >>> which makes logviewer-test failing. >>> - filed issue : https://issues.apache.org/jira/browse/STORM-1677 >>> and >>> submit a patch via pull request >>> - after applying PR, tests are all passed. >>> >>> - testing with binary distribution (one machine) : OK >>> - launch daemons : OK >>> - run RollingTopWords (local) : OK (with minor issue) >>> - process doesn't terminate until killing manually or pressing Ctrl >>>+ >>> C >>> - run RollingTopWords (remote) : OK >>> - activate / deactivate / rebalance / kill : OK >>> - logviewer (worker dir, daemon dir) : OK >>> - change log level : OK >>> - thread dump, heap dump, restart worker : OK >>> - run WordCountTopology (remote) : OK >>> - multiple workers and multi-lang bolt >>> >>> Minor but just leaving note: I saw /log (logviewer) throwing HTTP >>>STATUS >>> 500 sometimes, but I can't reproduce it. At that time, deep-search >>> doesn't >>> work at that topology, too. >>> >>> Total >>> - source distribution: -1 >>> - binary distribution: +1 >>> >>> I don't know how it is important to build with source distribution, but >>> we >>> can address STORM-1677 and initiate voting RC2 immediately although we >>> think it's a 'blocker' issue. >>> >>> Thanks, >>> Jungtaek Lim (HeartSaVioR) >>> >>> 2016년 4월 2일 (토) 오전 8:50, P. Taylor Goetz <[email protected]>님이 작성: >>> >>>> This is a call to vote on releasing Apache Storm 1.0.0 (rc1) >>>> >>>> Full list of changes in this release: >>>> >>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHAN >>>>GELOG.md;hb=787e4a6c375d290f724e59b3d8ebe34806ccd0d5 >>>> >>>> The tag/commit to be voted upon is v1.0.0: >>>> >>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=45b1b14840 >>>>1fd05f0f79cc7abdf6b5c7fc43df20;hb=d02f94268dec229d1125a24fdf53fa303cbc2 >>>>b29 >>>> >>>> The source archive being voted upon can be found here: >>>> >>>> >>>> >>>>https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.0/apache- >>>>storm-1.0.0-src.tar.gz >>>> >>>> Other release files, signatures and digests can be found here: >>>> >>>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.0/ >>>> >>>> The release artifacts are signed with the following key: >>>> >>>> >>>> >>>>https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS >>>>;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >>>> >>>> The Nexus staging repository for this release is: >>>> >>>> >>>>https://repository.apache.org/content/repositories/orgapachestorm-1027/ >>>> >>>> Please vote on releasing this package as Apache Storm 1.0.0. >>>> >>>> When voting, please list the actions taken to verify the release. >>>> >>>> This vote will be open for at least 72 hours. >>>> >>>> [ ] +1 Release this package as Apache Storm 1.0.0 >>>> [ ] 0 No opinion >>>> [ ] -1 Do not release this package because... >>>> >>>> Thanks to everyone who contributed to this release. This is a major >>>> milestone of which we should all be proud. >>>> >>>> This is not an April fools joke. ;) >>>> >>>> -Taylor >>>> >
