Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1217#discussion_r58601713
  
    --- Diff: storm-core/src/ui/public/js/script.js ---
    @@ -220,19 +220,21 @@ function topologyActionJson(id, encodedId, name, 
status, msgTimeout, debug, samp
         jsonData["deactivateStatus"] = (status === "ACTIVE") ? "enabled" : 
"disabled";
         jsonData["rebalanceStatus"] = (status === "ACTIVE" || status === 
"INACTIVE" ) ? "enabled" : "disabled";
         jsonData["killStatus"] = (status !== "KILLED") ? "enabled" : 
"disabled";
    -    jsonData["startDebugStatus"] = (status === "ACTIVE" && !debug) ? 
"enabled" : "disabled";
    +    jsonData["startDebugStatus"] = (status === "ACTIVE" && 
loggersTotal!=null && loggersTotal!=0 && !debug) ? "enabled" : "disabled";
    --- End diff --
    
    Since the intent is to disable event logging by default, we should  disable 
logging if topology.eventlogger.executors is null   ...  otherwise its 
confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to