Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1326#discussion_r59216852
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/internal/RateTracker.java ---
@@ -100,12 +99,6 @@ synchronized double reportRate(long currentTime) {
return events * 1000.0 / duration;
}
- public void close() {
- if (_task != null) {
- _task.cancel();
--- End diff --
It should have been called when the disruptor queue shuts down, but it
wasn't. Another bug.
https://github.com/abhishekagarwal87/storm/blob/STORM-1693/storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java#L392-L400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
