[
https://issues.apache.org/jira/browse/STORM-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261168#comment-15261168
]
ASF GitHub Bot commented on STORM-1733:
---------------------------------------
GitHub user dsKarthick opened a pull request:
https://github.com/apache/storm/pull/1372
STORM-1733 (0.9.x) Flush stdout and stderr before calling "os.execvp" to
prevent log loss.
Related to https://github.com/apache/storm/pull/1360/#issuecomment-215073019
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsKarthick/storm-1
flush_launch_command_to_stderr_0.9.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1372
----
commit 150d959aac646eac8267fb102e5d434cca4b3093
Author: Karthick Duraisamy Soundararaj <[email protected]>
Date: 2016-04-27T23:12:16Z
Flush stdout and stderr before calling os.execvp to prevent log loss.
----
> Logs from bin/storm are lost because stdout and stderr are not flushed
> ----------------------------------------------------------------------
>
> Key: STORM-1733
> URL: https://issues.apache.org/jira/browse/STORM-1733
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.3, 0.10.0, 0.9.4, 0.9.5, 0.9.6
> Reporter: Karthick Duraisamy Soundararaj
> Assignee: Karthick Duraisamy Soundararaj
>
> bin/storm.py emits the following crucial information that is lost because we
> don't flush the stdout before exec.
> {code}
> 2016-04-25T08:23:43.17141 Running: java -server -Dstorm.options=
> -Dstorm.home= -Xmx1024m -Dlogfile.name=nimbus.log
> -Dlogback.configurationFile=logback/cluster.xml backtype.storm.ui.core.nimbus
> {code}
> Observed Environment:
> {code}
> OS: CentOS release 6.5
> Kernel: 2.6.32-431.el6.x86_64
> Python version: Python 2.7.2
> {code}
> For example, I using runit to start storm components like nimbus, ui, etc and
> the problem is applicable to all the components and in all the cases, I am
> not seeing logs that are emitted by bin/storm before {{os.execvp}} is called
> to actually launch the component.
> Please note that in cases where stdout and stderr is terminal, the stdout and
> stderr are always flushed and the bug is not applicable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
