Canceling the vote to address the issue raised. -Taylor
> On Apr 28, 2016, at 11:51 AM, Harsha <[email protected]> wrote: > > storm-env.sh introduced if users want override any environment > variables. we can either comment out the line as default or what Taylor > proposed looks good too. > -Harsha > > On Thu, Apr 28, 2016, at 08:27 AM, P. Taylor Goetz wrote: >> HDP uses storm-env.sh, which is where it came from. That makes sense >> because I’ve noticed HDP builds exhibit the same issue. >> >> That line in storm-env.sh should probably be: >> >> if [ -n "$JAVA_HOME" ]; then export JAVA_HOME=${JAVA_HOME}; fi >> >> The fastest route would be to simply revert STORM-1706, but the correct >> thing to do might be to add the above to storm-env.sh (which would delay >> the release by 24 hrs.). >> >> Thoughts? >> >> -Taylor >> >> >> >>> On Apr 28, 2016, at 10:11 AM, Jungtaek Lim <[email protected]> wrote: >>> >>> Yeah, great finding. I agree it's critical so we should take an action. >>> >>> 1. storm-env.sh should be fixed to not re-set JAVA_HOME (btw, what exactly >>> is the meaning?) >>> 2. rename storm-env.sh to storm-env.sh.example (and also apply 1) >>> 3. just revert STORM-1706. >>> >>> Anything would be fine for me. >>> >>> 2016년 4월 28일 (목) 오후 10:58, P. Taylor Goetz <[email protected]>님이 작성: >>> >>>> STORM-1706 introduced it. Before 1.0.1 we weren’t including >>>> `storm-env.sh`. That file does the following: >>>> >>>> export JAVA_HOME=${JAVA_HOME} >>>> >>>> Which, if JAVA_HOME is not set, will set it, but leave it empty. So the >>>> clj `if (nil? java-home)` will evaluate to false and we’ll end up with >>>> `/bin/java` as the java command. >>>> >>>> I think we need to revert STORM-1706. >>>> >>>> -Taylor >>>> >>>>> On Apr 28, 2016, at 9:26 AM, P. Taylor Goetz <[email protected]> wrote: >>>>> >>>>> Yeah, that section hasn’t changed. I think it’s a change further up the >>>> stack. >>>>> >>>>>> On Apr 28, 2016, at 9:05 AM, Jungtaek Lim <[email protected]> wrote: >>>>>> >>>>>> It's here. >>>>>> >>>>>> (defn jvm-cmd [cmd] >>>>>> (let [java-home (.get (System/getenv) "JAVA_HOME")] >>>>>> (if (nil? java-home) >>>>>> cmd >>>>>> (str java-home file-path-separator "bin" file-path-separator cmd)))) >>>>>> >>>>>> If JAVA_HOME isn't set to system environment, it may works as what we >>>> want. >>>>>> But if it's set to empty string, "/bin/java" will be called. >>>>>> >>>>>> >>>>>> >>>>>> 2016년 4월 28일 (목) 오후 10:01, P. Taylor Goetz <[email protected]>님이 작성: >>>>>> >>>>>>> >>>>>>> >>>>>>>> On Apr 28, 2016, at 2:30 AM, Jungtaek Lim <[email protected]> wrote: >>>>>>>> >>>>>>>> - if we don't set JAVA_HOME, supervisor runs "/bin/java" instead of >>>>>>> "java" >>>>>>>> when it launches worker with non-secure mode. >>>>>>> >>>>>>> That seems like a regression we don't want. I'll look into where that >>>> came >>>>>>> from >>>>>>> >>>>>>> -Taylor >>>>> >>>> >>>> >> >> Email had 1 attachment: >> + signature.asc >> 1k (application/pgp-signature)
signature.asc
Description: Message signed with OpenPGP using GPGMail
