[
https://issues.apache.org/jira/browse/STORM-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262524#comment-15262524
]
ASF GitHub Bot commented on STORM-1741:
---------------------------------------
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1377
STORM-1741: remove unconditional setting of JAVA_HOME from storm-env.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm STORM-1741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1377
----
commit 862e468c3bbf632e9ed1e6efc204ef69e55af55f
Author: P. Taylor Goetz <ptgo...@gmail.com>
Date: 2016-04-28T16:58:44Z
remove unconditional setting of JAVA_HOME from storm-env.sh
----
> storm-env.sh unconditionally sets JAVA_HOME
> -------------------------------------------
>
> Key: STORM-1741
> URL: https://issues.apache.org/jira/browse/STORM-1741
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 1.0.1
> Reporter: P. Taylor Goetz
> Assignee: P. Taylor Goetz
> Priority: Blocker
> Fix For: 1.0.1
>
>
> STORM-1706 introduced storm-env.sh to the binary distribution. Before 1.0.1
> we weren’t including `storm-env.sh`. That file does the following:
> export JAVA_HOME=${JAVA_HOME}
> Which, if JAVA_HOME is not set, will set it, but leave it empty. So the
> clojure code in supervisor.clj `if (nil? java-home)` will evaluate to false
> and we’ll end up with `/bin/java` as the java command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
