[ 
https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270211#comment-15270211
 ] 

ASF GitHub Bot commented on STORM-1755:
---------------------------------------

Github user abhishekagarwal87 commented on the pull request:

    https://github.com/apache/storm/pull/1386#issuecomment-216762280
  
    It's about both the consumer and producer api. 0.9.x client (producer + 
consumer) is not backward compatible with 0.8.x broker. 
    
    Reverting this version change has two purposes- 
    1. Upgrading to new version of storm-kafka will work with 0.8.x cluster 
without any surprises like 
    
https://mail-archives.apache.org/mod_mbox/storm-user/201605.mbox/%3CCAFwSPC1072CkOWsGB48HBOoMx%3D5h88AJ22sCBcJ31cB1Uqg52w%40mail.gmail.com%3E.
 
    
    2. More importantly, by explicitly setting version to 0.8.x, we will ensure 
that in future no changes are made to storm-kafka which are not compatible with 
older kafka client (since compilation itself will fail). In fact, I will also 
add this comment in the storm-kafka pom so that kafka version is not upgraded 
in future. 
    
    By the way, version is being reverted only for storm-kafka module. The new 
kafka client for storm (storm-kafka-client) still uses 0.9.x. I think we should 
encourage the use of this module if user need features specific to 0.9.x 
version. We already have the consumer api available there. we can do the same 
for producer api. Happy to take it up. 


> Revert the kafka client version upgrade in storm-kafka module
> -------------------------------------------------------------
>
>                 Key: STORM-1755
>                 URL: https://issues.apache.org/jira/browse/STORM-1755
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>    Affects Versions: 1.0.1
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>
> storm-kafka module does not use any feature of new API. The newer kafka 
> client (0.9.x) is not backward compatible with 0.8.x brokers and upgrading 
> storm-kafka version in topology could break the currently running topologies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to