[
https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270393#comment-15270393
]
ASF GitHub Bot commented on STORM-1700:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1324#discussion_r62013271
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -383,10 +384,16 @@ public static void addEventLogger(Map conf,
StormTopology topology) {
for (Map<String, Object> info : registerInfo) {
String className = (String) info.get("class");
Object argument = info.get("argument");
+ Integer maxRetainMetricTuples =
Utils.getInt(info.get("max.retain.metric.tuples"), 100);
--- End diff --
let the default come from defaults.yaml
> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -------------------------------------------------------------
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules
> (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of
> metrics. If MetricsConsumer cannot keep up with these metrics, only way to
> keep up is increasing parallelism, which seems limited. Furthermore, some
> users don't want to care about some metrics since unintended metrics will
> fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better
> to support filter by Storm side. It will reduce the redundant works for Storm
> community.
> If we provide filter options, it would be great.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
