GitHub user fbyrne opened a pull request:
https://github.com/apache/storm/pull/1400
STORM-1730 LocalCluster#shutdown() does not terminate all storm
threads/thread pools.
The thread pool executor used by the `DisruptorQueue.FlusherPool` is in a
static context of the
DisruptorQueue. To avoid major changes to how this queues lifecycle is
managed I added a simple fix is to create a thread pool factory which
creates daemon
threads. The threads are now also named with the 'disruptor-flush'
prefix to be consistent with the TimerTask.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fbyrne/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1400
----
commit 3c78314e18e21cd188cd7b8e5ae3f2143ed75cbd
Author: Fergus Byrne <[email protected]>
Date: 2016-05-05T16:32:33Z
STORM-1730 LocalCluster#shutdown() does not terminate all storm
threads/thread pools.
The thread pool that is remaining is in a static context of the
DisruptorQueue. To avoid major changes to how this queues lifecycle is
managed the fix is to create a thread pool factory which creates daemon
threads. The threads are now also named with the 'disruptor-flush'
prefix to be consistent with the TimerTask.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
