Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1419#issuecomment-219533584
@flisky can you please share the code, or at least the steps to reproduce
the scenario where this code does not work? Another alternative is that you
enable all the logging levels for us to understand what is happening. That
could should be necessary, and I am not very comfortable just removing it
without understanding what is going on.
Without that code, I believe that the scenario where a consumer rebalance
occurs, and offsets 1,2 have been hacked, but 3 is still pending, and 4, 5 have
also been acked, won't work. That code is there to cover for this scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
