Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1410#discussion_r63456723
  
    --- Diff: 
external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/KafkaDataSourcesProvider.java
 ---
    @@ -171,12 +171,23 @@ public ISqlTridentDataSource constructTrident(URI 
uri, String inputFormatClass,
           }
         }
         Preconditions.checkState(primaryIndex != -1, "Kafka stream table must 
have a primary key");
    -    conf.scheme = new SchemeAsMultiScheme(new JsonScheme(fieldNames));
         ObjectMapper mapper = new ObjectMapper();
         Properties producerProp = new Properties();
         try {
           @SuppressWarnings("unchecked")
           HashMap<String, Object> map = mapper.readValue(properties, 
HashMap.class);
    +      if(!map.containsKey("scheme")){
    --- End diff --
    
    Please fix spaces between L179 and L187.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to