[ 
https://issues.apache.org/jira/browse/STORM-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285891#comment-15285891
 ] 

ASF GitHub Bot commented on STORM-1778:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1410#discussion_r63456723
  
    --- Diff: 
external/sql/storm-sql-kafka/src/jvm/org/apache/storm/sql/kafka/KafkaDataSourcesProvider.java
 ---
    @@ -171,12 +171,23 @@ public ISqlTridentDataSource constructTrident(URI 
uri, String inputFormatClass,
           }
         }
         Preconditions.checkState(primaryIndex != -1, "Kafka stream table must 
have a primary key");
    -    conf.scheme = new SchemeAsMultiScheme(new JsonScheme(fieldNames));
         ObjectMapper mapper = new ObjectMapper();
         Properties producerProp = new Properties();
         try {
           @SuppressWarnings("unchecked")
           HashMap<String, Object> map = mapper.readValue(properties, 
HashMap.class);
    +      if(!map.containsKey("scheme")){
    --- End diff --
    
    Please fix spaces between L179 and L187.


> Scheme Extension Framework for KafkaDataSource and support for CSV format
> -------------------------------------------------------------------------
>
>                 Key: STORM-1778
>                 URL: https://issues.apache.org/jira/browse/STORM-1778
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-sql
>            Reporter: Chuanlei Ni
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to