Github user barrywhart commented on the pull request:
https://github.com/apache/storm/pull/1423#issuecomment-219707172
The change looks good to me.
Are the build failures related to this change?
https://travis-ci.org/apache/storm/jobs/130816708#L1162
It looks like something unrelated:
```[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default)
on project storm-hive: Error resolving project artifact: Could not transfer
artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.3-jhyde from/to
sonatype-apache (https://repository.apache.org/releases/): Connect to
repository.apache.org:443 [repository.apache.org/140.211.11.112] failed:
Connection timed out for project
org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.3-jhyde -> [Help 1]```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---