[
https://issues.apache.org/jira/browse/STORM-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286589#comment-15286589
]
ASF GitHub Bot commented on STORM-1730:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1400#issuecomment-219713855
@fbyrne Sorry we don't have it explicitly for Java now, we only have
Clojure style guide.
Part of the plan for Storm 2.0.0 is porting Clojure to Java. After that we
would have style guide / formatter for Java.
For now let's see style of origin code and adopt ourselves.
What I pointed out is indentation difference between L74, L75, L79. Could
you address to let indentation consistent?
> LocalCluster#shutdown() does not terminate all storm threads/thread pools.
> --------------------------------------------------------------------------
>
> Key: STORM-1730
> URL: https://issues.apache.org/jira/browse/STORM-1730
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Environment: Windows 7 x64
> Oracle Java 1.8.0 u92 x64
> Reporter: Fergus Byrne
> Assignee: Fergus Byrne
> Priority: Minor
> Attachments: Thread Pool '47' remaining..png, storm-shutdown-issue.zip
>
>
> When using the LocalCluster in test setup. LocalCluster#shutdown() does not
> shutdown all executor services it starts. In my test case, there is a single
> thread pool executor service that is not shutdown and not daemon. This keeps
> the jvm alive when it is expected to terminate.
> Please see attached test case. In my example, thread pool 47 is not
> shutdown. Naming here is conditional on threading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
