[
https://issues.apache.org/jira/browse/STORM-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288181#comment-15288181
]
Jungtaek Lim edited comment on STORM-1846 at 5/18/16 4:22 AM:
--------------------------------------------------------------
I thought it's easy to handle since we just set the pythonpath to include
storm-core/src/py and run "echo 'from storm import ttypes' | python", and see
the return code.
(Maybe we want to set PYTHONPATH and running echo at once.)
But it has preconditions which in fact makes this not easy to handle without
forcing developer to do something.
# thrift should be installed to not getting error from 'import storm.ttypes'.
## we could even create another python script which import thrift first, and
skip actual import if it fails to import thrift. Test may always pass on
developer machine, but can fail on Travis CI since we can modify .travis.yml to
install 'thrift' before testing.
# path should include python (or python.exe in Windows).
Since we got rid of multilang tests so AFAIK there's no requirement to have
python, ruby, nodejs.
It requires to have python again, which seems not good even though Linux
distributions / OSX normally have python installed by default.
was (Author: kabhwan):
I thought it's easy to handle since we just set the pythonpath to include
storm-core/src/py and run "echo 'from storm import ttypes' | python", and see
the return code.
(Maybe we want to set PYTHONPATH and running echo at once.)
But it has preconditions which in fact makes this not easy to handle without
forcing developer to do something.
# thrift should be installed to not getting error from 'import storm.ttypes'.
## we could even create another python script which import thrift first, and
skip actual import if it fails to import thrift.
# path should include python (or python.exe in Windows).
Since we got rid of multilang tests so AFAIK there's no requirement to have
python, ruby, nodejs.
It requires to have python again, which seems not good even though Linux
distributions / OSX normally have python installed by default.
> Need a smoke test for the generated Python code
> -----------------------------------------------
>
> Key: STORM-1846
> URL: https://issues.apache.org/jira/browse/STORM-1846
> Project: Apache Storm
> Issue Type: Test
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Barry Hart
>
> This was inspired by STORM-1842. For that issue, simply attempting to import
> ttypes.py would've detected the error. I'm guessing there is no such test. It
> would be good to add one in order to help avoid problems like that in the
> future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
