Github user hmcl commented on the pull request:

    https://github.com/apache/storm/pull/1422#issuecomment-220407078
  
    @vesense what is the motivation behind this change? Prior to your proposed 
change, the charset used is the one that is defined by the java system property 
`file.encoding`. If this property is absent  the file encoding used will be 
`UTF-8` in JDK8. 
    
    My understanding is that your proposed change will eliminate the chance to 
customize an arbitrary charset using `file.encoding`. Is this the goal?
    
    If the goal is to set `UTF-8` by default, perhaps once should simply set in 
a configuration file the property `file.encoding=UTF-8`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to